New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next and Previous buttons cannot be operated via keyboard. #430

Closed
sarbbottam opened this Issue Jun 23, 2017 · 2 comments

Comments

2 participants
@sarbbottam

sarbbottam commented Jun 23, 2017

The next and previous buttons are implemented using <span>, thus they are not operable via enter or space press. Please consider it replacing with <button>.

Pros

  • tabindex=0 is no more needed, <button> is a focusable element
  • role=button is no more needed, <button> exposes the role by default
  • previousClickHandler and nextClickHandler will get invoked when the buttons are activated using keyboard.

Cons

  • might need to update the styles
@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Jun 23, 2017

Owner

An old implementation still biting the component 😔

I believe a better workaround would be a onKeyDown event added to the span, so we can skip the major release 🙌

Thanks for the report!

Owner

gpbl commented Jun 23, 2017

An old implementation still biting the component 😔

I believe a better workaround would be a onKeyDown event added to the span, so we can skip the major release 🙌

Thanks for the report!

@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Jun 26, 2017

Owner

Fixed in v6.04.

Owner

gpbl commented Jun 26, 2017

Fixed in v6.04.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment