New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-day-picker is misusing the application role #548

Closed
trezy opened this Issue Nov 15, 2017 · 4 comments

Comments

2 participants
@trezy

trezy commented Nov 15, 2017

According to the W3C:

...the role of application should only be used with caution because it gives a signal to screen reading software to turn off normal web navigation controls. Simple widgets should generally not be given the application role, nor should an entire web page be given the application role, unless it is not to be used at all like a web page, and not without much user testing with assistive technology.)

However, react-day-picker has the application role.

@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Nov 15, 2017

Owner

@trezy thanks for pointing this out - which role should be used instead?

Owner

gpbl commented Nov 15, 2017

@trezy thanks for pointing this out - which role should be used instead?

@gpbl gpbl added the a11y label Nov 15, 2017

@trezy

This comment has been minimized.

Show comment
Hide comment
@trezy

trezy Nov 15, 2017

@gpbl, props for the a11y label and the awesome amount of ARIA implementation in this plugin! For this library, I think you're best just sticking with the grid role which is already set up. It's already a subclass of the widget role, which indicates specifically that it isn't an application. Just removing the application role would be sufficient to bring it back in line with ARIA.

trezy commented Nov 15, 2017

@gpbl, props for the a11y label and the awesome amount of ARIA implementation in this plugin! For this library, I think you're best just sticking with the grid role which is already set up. It's already a subclass of the widget role, which indicates specifically that it isn't an application. Just removing the application role would be sufficient to bring it back in line with ARIA.

@gpbl gpbl added this to the v6.3.0 milestone Nov 15, 2017

gpbl added a commit that referenced this issue Nov 15, 2017

@gpbl gpbl closed this in #551 Nov 15, 2017

gpbl added a commit that referenced this issue Nov 15, 2017

gpbl added a commit that referenced this issue Nov 15, 2017

@trezy

This comment has been minimized.

Show comment
Hide comment
@trezy

trezy Nov 17, 2017

@gpbl Thanks for doing that work! It's always awesome to see an OSS project doing so well. 😁

trezy commented Nov 17, 2017

@gpbl Thanks for doing that work! It's always awesome to see an OSS project doing so well. 😁

@gpbl gpbl modified the milestones: v6.3.0, v7.0.0 Nov 25, 2017

@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Nov 25, 2017

Owner

You are welcome, thanks for the support. I published the change in v7

Owner

gpbl commented Nov 25, 2017

You are welcome, thanks for the support. I published the change in v7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment