New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DayPicker-Weekdays should have a table-row as child #82

Closed
gpbl opened this Issue Nov 11, 2015 · 1 comment

Comments

2 participants
@gpbl
Owner

gpbl commented Nov 11, 2015

As pointed out by @nkbt, this commit broke some styles, so the proposed solution by @JKillian is to remove display: table-row in the CSS.

However it is preferred to have a table-row inside DayPicker-Weekdays, which is a table-header-group.

So we should revert that commit and restore the surrounding div. This div was however missing a className, thus the confusion that lead to this problem: I'd assign to this element the DayPicker-Weekdays-row class.

@nkbt

This comment has been minimized.

Show comment
Hide comment
@nkbt

nkbt Nov 11, 2015

Oh, so I actually ran into bug. Thanks for the prompt fix!

nkbt commented Nov 11, 2015

Oh, so I actually ran into bug. Thanks for the prompt fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment