New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in fromMonth/toMonth and showMonth method #95

Closed
JKillian opened this Issue Nov 19, 2015 · 4 comments

Comments

2 participants
@JKillian
Contributor

JKillian commented Nov 19, 2015

Say toMonth is set to December 2015 and someone tried to call showMonth(new Date(2015,11)) in order to display December 2015.

allowMonth incorrectly returns false as toMonth and d are the same month. It should return true. I believe this should be a simple fix by changing Helpers.getMonthsDiff(toMonth, d) >= 0 to Helpers.getMonthsDiff(toMonth, d) > 0 (and doing the same for fromMonth).

@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Nov 20, 2015

Owner

Published as v1.1.5 🤖

Owner

gpbl commented Nov 20, 2015

Published as v1.1.5 🤖

@JKillian

This comment has been minimized.

Show comment
Hide comment
@JKillian

JKillian Nov 20, 2015

Contributor

@gpbl think you forgot to run the build for bower 😉

Contributor

JKillian commented Nov 20, 2015

@gpbl think you forgot to run the build for bower 😉

@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Nov 20, 2015

Owner

Grrr yes sure... I have to remember to run the prerelease task each time... because that boring prepublish thing in npm :(

Anyway, I would not publish a new npm release for this. I just updated dist and tagged 1.1.6 – bower should catch it, right?

Owner

gpbl commented Nov 20, 2015

Grrr yes sure... I have to remember to run the prerelease task each time... because that boring prepublish thing in npm :(

Anyway, I would not publish a new npm release for this. I just updated dist and tagged 1.1.6 – bower should catch it, right?

@JKillian

This comment has been minimized.

Show comment
Hide comment
@JKillian

JKillian Nov 20, 2015

Contributor

Yep, that should work - thanks!

Contributor

JKillian commented Nov 20, 2015

Yep, that should work - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment