Conversation
|
The problem is that for months with 4 or 5 weeks you'll see a weird empty space. With this you can ensure that the calendar will show data for them. |
|
I'm going to fix those eslint issues. |
|
However, for months having just four weeks, you would see two weeks more from the next month, which is also weird. I think such graphic glitches should not be handled by this component. How are other implementations handling with this? |
|
This flag is disabled by default. I mean, you will see those extra weeks only when you have this flag enabled. I won't be weird because is what people will expect. The problem is that those "graphic glitches" can only be handled by this component. An external wrapper can not do any trick to avoid blank spaces. Was #133 trying to solve the same problem? |
|
Thanks for replying! Yes, in the OS X date picker I see this behavior implemented as well – so I changed my mind :) I never payed attention to this. I'd call this prop |
|
Great! I'm going to change the flag name and fix those eslint errors. 👏 |
With this new flag, the calendar will show always the same number of weeks. Exactly 6, because is the maximum number of week that a month can have.
13cb2b1 to
e3a4471
Compare
|
Awesome thanks |
|
👏 Thanks! |
|
Could you release it, please? |
|
I want first to update the docs and the examples :) While trying this prop, I wonder if |
|
I was thinking about that during development. Maybe you want to avoid the graphic glitches but don't want to see outside days. Weird case indeed. I don't have a strong opinion about it. |
|
@fcsonline So my position here is to enable them. Outside days can always be disabled by setting the prop to |
|
So you mean to enable it if is |
|
Uhm nope the default value for the prop is |
|
Cool! |
Add docs, fix behavior of outside days for fixedWeeks (#176)
|
Published as v2.2.0! example |
|
Thanks! |
Problem
If your calendar is in a container with other elements around and you move between months, the container resizes to the number of weeks shown and this can create an annoying effect.
Solution
Added fixedWeeks flag
With this new flag, the calendar will show always the same number of
weeks. Exactly 6, because is the maximum number of week that a month can
have.
You can see here an example with this flag enabled: