New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add navbarElement and weekdayElement props #179

Merged
merged 4 commits into from Jun 10, 2016

Conversation

3 participants
@boatkorachal
Contributor

boatkorachal commented Jun 9, 2016

from #177

@boatkorachal boatkorachal referenced this pull request Jun 9, 2016

Closed

Add navbarElement prop #177

@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Jun 10, 2016

Owner

Hi @boatkorachal thanks for the help and congrats for your first PR 🎊

To maintain backward compatibility, we should not remove these *Component props. My idea was actually to add two new props. We could eventually deprecate them. Sorry for not being clear enough: I'll add some comments to your PR.

Owner

gpbl commented Jun 10, 2016

Hi @boatkorachal thanks for the help and congrats for your first PR 🎊

To maintain backward compatibility, we should not remove these *Component props. My idea was actually to add two new props. We could eventually deprecate them. Sorry for not being clear enough: I'll add some comments to your PR.

@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Jun 10, 2016

Owner

(You should rebase your branch with master to fix these conflicts)

Owner

gpbl commented Jun 10, 2016

(You should rebase your branch with master to fix these conflicts)

Show outdated Hide outdated src/DayPicker.js
Show outdated Hide outdated src/DayPicker.js
Show outdated Hide outdated src/DayPicker.js
@boatkorachal

This comment has been minimized.

Show comment
Hide comment
@boatkorachal

boatkorachal Jun 10, 2016

Contributor

ewww i just did the rebase and force push. hope that i haven't done anything wrong :)

Contributor

boatkorachal commented Jun 10, 2016

ewww i just did the rebase and force push. hope that i haven't done anything wrong :)

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 10, 2016

Coverage Status

Coverage decreased (-0.3%) to 99.732% when pulling 34bff97 on boatkorachal:navbar-and-weekday-element into 405d62a on gpbl:master.

coveralls commented Jun 10, 2016

Coverage Status

Coverage decreased (-0.3%) to 99.732% when pulling 34bff97 on boatkorachal:navbar-and-weekday-element into 405d62a on gpbl:master.

@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Jun 10, 2016

Owner

Yay thanks! Could you even test that the rendered component is actually the navbarElement? 🙏
https://coveralls.io/builds/6541993/source?filename=src%2FDayPicker.js#L357

Owner

gpbl commented Jun 10, 2016

Yay thanks! Could you even test that the rendered component is actually the navbarElement? 🙏
https://coveralls.io/builds/6541993/source?filename=src%2FDayPicker.js#L357

@boatkorachal

This comment has been minimized.

Show comment
Hide comment
@boatkorachal

boatkorachal Jun 10, 2016

Contributor

Isn't it checked at proptypes? or should I import react-addons-test-utils and change to something like this

if ( TestUtils.isElement(navbarElement) ) {
  return React.cloneElement(navbarElement, props)
}
Contributor

boatkorachal commented Jun 10, 2016

Isn't it checked at proptypes? or should I import react-addons-test-utils and change to something like this

if ( TestUtils.isElement(navbarElement) ) {
  return React.cloneElement(navbarElement, props)
}
@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Jun 10, 2016

Owner

The test coverage has been decreased, this is because we didn't include a test to check if passing a navbarElement did actually render the element. See https://coveralls.io/builds/6541993/source?filename=src%2FDayPicker.js#L357

Actually, even weekdayElement hasn't be checked: I wonder we are actually rendering it :)
I can't work on this now, so that's why I'm asking :)

Owner

gpbl commented Jun 10, 2016

The test coverage has been decreased, this is because we didn't include a test to check if passing a navbarElement did actually render the element. See https://coveralls.io/builds/6541993/source?filename=src%2FDayPicker.js#L357

Actually, even weekdayElement hasn't be checked: I wonder we are actually rendering it :)
I can't work on this now, so that's why I'm asking :)

@boatkorachal

This comment has been minimized.

Show comment
Hide comment
@boatkorachal

boatkorachal Jun 10, 2016

Contributor

I have just update tests. Is it ok? (I have to admit that this is the first time i write the tests too haha)

Contributor

boatkorachal commented Jun 10, 2016

I have just update tests. Is it ok? (I have to admit that this is the first time i write the tests too haha)

@boatkorachal

This comment has been minimized.

Show comment
Hide comment
@boatkorachal

boatkorachal Jun 10, 2016

Contributor

oh sorry i forgot to run lint. i'm gonna fix it now.

Contributor

boatkorachal commented Jun 10, 2016

oh sorry i forgot to run lint. i'm gonna fix it now.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 10, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 9878237 on boatkorachal:navbar-and-weekday-element into 405d62a on gpbl:master.

coveralls commented Jun 10, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 9878237 on boatkorachal:navbar-and-weekday-element into 405d62a on gpbl:master.

@gpbl gpbl merged commit e4fa65d into gpbl:master Jun 10, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Jun 10, 2016

Owner

Looks good! Thanks a lot!

Owner

gpbl commented Jun 10, 2016

Looks good! Thanks a lot!

@gpbl gpbl referenced this pull request Jun 13, 2016

Closed

New dayElement prop #89

@gpbl gpbl changed the title from navbarElement and weekdayElement instead of component to Add navbarElement and weekdayElement props Jun 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment