New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build the output files as a UMD module #216

Merged
merged 2 commits into from Sep 29, 2016

Conversation

4 participants
@pguimera
Contributor

pguimera commented Sep 28, 2016

As the title says, I've updated webpack's output to build the file as a UMD module to improve the library's compatibility when using the built file directly.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Sep 28, 2016

Coverage Status

Coverage remained the same at 99.738% when pulling 3a77b9f on pguimera:umd-module into 4ba2b05 on gpbl:master.

coveralls commented Sep 28, 2016

Coverage Status

Coverage remained the same at 99.738% when pulling 3a77b9f on pguimera:umd-module into 4ba2b05 on gpbl:master.

@gpbl

Awesome, thanks! Does this mean we can directly call the package from https://unpkg.com as well? 😃

Show outdated Hide outdated .gitignore
Show outdated Hide outdated package.json
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Sep 29, 2016

Coverage Status

Coverage remained the same at 99.738% when pulling c5f6705 on pguimera:umd-module into 4ba2b05 on gpbl:master.

coveralls commented Sep 29, 2016

Coverage Status

Coverage remained the same at 99.738% when pulling c5f6705 on pguimera:umd-module into 4ba2b05 on gpbl:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Sep 29, 2016

Coverage Status

Coverage remained the same at 99.738% when pulling 444e84c on pguimera:umd-module into 4ba2b05 on gpbl:master.

coveralls commented Sep 29, 2016

Coverage Status

Coverage remained the same at 99.738% when pulling 444e84c on pguimera:umd-module into 4ba2b05 on gpbl:master.

@pguimera

This comment has been minimized.

Show comment
Hide comment
@pguimera

pguimera Sep 29, 2016

Contributor

I've cleaned the history a bit whilst applying the suggested changes. Also, in regards to the https://unpkg.com integration there's additional steps to be made (based from this changes) which are specified in the SUGGESTED WORKFLOW section of said page.

Contributor

pguimera commented Sep 29, 2016

I've cleaned the history a bit whilst applying the suggested changes. Also, in regards to the https://unpkg.com integration there's additional steps to be made (based from this changes) which are specified in the SUGGESTED WORKFLOW section of said page.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Sep 29, 2016

Coverage Status

Coverage remained the same at 99.738% when pulling 444e84c on pguimera:umd-module into 4ba2b05 on gpbl:master.

coveralls commented Sep 29, 2016

Coverage Status

Coverage remained the same at 99.738% when pulling 444e84c on pguimera:umd-module into 4ba2b05 on gpbl:master.

@gpbl gpbl merged commit 33e184f into gpbl:master Sep 29, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 99.738%
Details
@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Sep 29, 2016

Owner

Thanks a lot! I'll work on the unpkg thing before releasing on npm.

Owner

gpbl commented Sep 29, 2016

Thanks a lot! I'll work on the unpkg thing before releasing on npm.

@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Oct 6, 2016

Owner

Hey @pguimera,

I've published v2.5.0. It works now from unpkg as well 🙌

Owner

gpbl commented Oct 6, 2016

Hey @pguimera,

I've published v2.5.0. It works now from unpkg as well 🙌

@pguimera

This comment has been minimized.

Show comment
Hide comment
@pguimera

pguimera Oct 6, 2016

Contributor

Awesome news @gpbl, thanks for that.

I can now use this amazing library in my project without having to do weird tricks in my tooling 😄

Contributor

pguimera commented Oct 6, 2016

Awesome news @gpbl, thanks for that.

I can now use this amazing library in my project without having to do weird tricks in my tooling 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment