New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure weekday labels respect the locale’s `firstDayOfWeek` #220

Merged
merged 4 commits into from Oct 11, 2016

Conversation

3 participants
@makenosound
Contributor

makenosound commented Oct 10, 2016

I noticed today that the firstDayOfWeek locale setting isn’t respected by the weekday headings.

This change passes through that prop to the <Weekdays> component and then appropriately normalises it to a 0-6 integer using the modulo operator so that they do match up to the dates below.

makenosound added a commit to icelab/formalist-standard-react that referenced this pull request Oct 10, 2016

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 10, 2016

Coverage Status

Coverage increased (+0.0007%) to 99.74% when pulling 45c6611 on makenosound:fix-weekday-labels into 2e44ec7 on gpbl:master.

coveralls commented Oct 10, 2016

Coverage Status

Coverage increased (+0.0007%) to 99.74% when pulling 45c6611 on makenosound:fix-weekday-labels into 2e44ec7 on gpbl:master.

@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Oct 10, 2016

Owner

Thanks! Is it possible for you to add a test to reproduce this? I believe it is a fix for #207 – I need to investigate this bug better, but it looks it is a potentially breaking change.

Owner

gpbl commented Oct 10, 2016

Thanks! Is it possible for you to add a test to reproduce this? I believe it is a fix for #207 – I need to investigate this bug better, but it looks it is a potentially breaking change.

@makenosound

This comment has been minimized.

Show comment
Hide comment
@makenosound

makenosound Oct 10, 2016

Contributor

@gpbl Yep, will add a test when I get a chance!

I don't think it should be a breaking change though, since it's just passing through some additional data.

Contributor

makenosound commented Oct 10, 2016

@gpbl Yep, will add a test when I get a chance!

I don't think it should be a breaking change though, since it's just passing through some additional data.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 10, 2016

Coverage Status

Coverage increased (+0.0007%) to 99.74% when pulling 20e2117 on makenosound:fix-weekday-labels into 2e44ec7 on gpbl:master.

coveralls commented Oct 10, 2016

Coverage Status

Coverage increased (+0.0007%) to 99.74% when pulling 20e2117 on makenosound:fix-weekday-labels into 2e44ec7 on gpbl:master.

@makenosound

This comment has been minimized.

Show comment
Hide comment
@makenosound

makenosound Oct 10, 2016

Contributor

@gpbl I’ve added a test for that now, and yep, it should fix up #207.

Contributor

makenosound commented Oct 10, 2016

@gpbl I’ve added a test for that now, and yep, it should fix up #207.

@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Oct 11, 2016

Owner

Thanks @makenosound for your help!

Owner

gpbl commented Oct 11, 2016

Thanks @makenosound for your help!

@gpbl gpbl merged commit b965b7e into gpbl:master Oct 11, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0007%) to 99.74%
Details

gpbl added a commit that referenced this pull request Oct 11, 2016

gpbl added a commit that referenced this pull request Oct 11, 2016

@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Oct 11, 2016

Owner

Published as v3 👍

Owner

gpbl commented Oct 11, 2016

Published as v3 👍

@makenosound

This comment has been minimized.

Show comment
Hide comment
@makenosound

makenosound Oct 11, 2016

Contributor

No worries, @gpbl. Thanks for the great little lib.

Contributor

makenosound commented Oct 11, 2016

No worries, @gpbl. Thanks for the great little lib.

@gpbl gpbl referenced this pull request Oct 14, 2016

Closed

Start day Monday #223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment