New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New containerProps prop #255

Merged
merged 3 commits into from Feb 14, 2017

Conversation

2 participants
@gpbl
Owner

gpbl commented Feb 14, 2017

This new prop remove the previous behavior of props being spread to the container's <div /> element by default. Instead, developers should use containerProps:

<DayPicker 
-    data-my-thing="foo" 
+    containerProps={ 'data-my-thing': 'foo' }
/>

This will avoid to loop over the prop types to remove the invalid ones, improving rendering performance as suggested here.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 14, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling cd980ab on container-props into ecc30be on master.

coveralls commented Feb 14, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling cd980ab on container-props into ecc30be on master.

@gpbl gpbl merged commit 45d5e5e into master Feb 14, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

@gpbl gpbl deleted the container-props branch Feb 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment