New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add classNames prop (#73) #264

Merged
merged 2 commits into from Feb 25, 2017

Conversation

2 participants
@gpbl
Owner

gpbl commented Feb 25, 2017

This PR adds a new classNames prop to customize the name of the CSS classes used when rendering the component.

By specifying the className for each element, the original BEM syntax can be skipped. The styles can be imported then with CSS Modules. The expected classnames are specified in the proptypes.

To keep the original BEM syntax, the components adopt an object mapping the previous class names. If the classNames object is the same as the default, it will switch to the original behavior.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 25, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 6e1d117 on css-modules into 97f2a48 on master.

coveralls commented Feb 25, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 6e1d117 on css-modules into 97f2a48 on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 25, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling e8093c4 on css-modules into 97f2a48 on master.

coveralls commented Feb 25, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling e8093c4 on css-modules into 97f2a48 on master.

@gpbl gpbl merged commit 028decb into master Feb 25, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

@gpbl gpbl deleted the css-modules branch Feb 25, 2017

@gpbl gpbl changed the title from Add classNames prop (close #73) to Add classNames prop (#73) Feb 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment