New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyboard navigation with custom classNames #269

Merged
merged 1 commit into from Mar 6, 2017

Conversation

3 participants
@oigewan

oigewan commented Mar 5, 2017

Fixes #268

Changes:
This will remove the assumptions about the CSS classes in the DayPicker.getDayNodes method. Since users can pass in multiple, space delimited classes, we'll need to be a bit careful about how we build up the query. Also relevant to note: This is tied really tightly to the implementation details of modifiers (sometimes it's a combination of the day and modifier, sometimes it's not). Not sure if that's the best way going forward, but I wanted to keep changes tightly scoped for this patch.

Also added some tests for the custom classNames use case. They're basically copies of existing tests with the selectors changed up to match the custom classNames being passed in.

cc @gpbl

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 5, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling b1bb95f on oigewan:dayNodesBug into f17191d on gpbl:master.

coveralls commented Mar 5, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling b1bb95f on oigewan:dayNodesBug into f17191d on gpbl:master.

@gpbl gpbl merged commit 512a72b into gpbl:master Mar 6, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

gpbl added a commit that referenced this pull request Mar 6, 2017

@oigewan oigewan deleted the oigewan:dayNodesBug branch Mar 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment