New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 'today' modifier to override default #279

Merged
merged 2 commits into from Mar 8, 2017

Conversation

3 participants
@maxdubrinsky
Contributor

maxdubrinsky commented Mar 8, 2017

The product I am working on allows users to specify a timezone other than that of their browsers, and in doing so might cause what the day picker component thinks today is to be different from what the user expects. This change simply allows me to override the today modifier with a custom function that could use other references, such as moment-timezone objects.

This was run with test, cover, and lint, but if there are other modifications necessary, please let me know.

Thanks, and I welcome your feedback!

Show outdated Hide outdated src/DayPicker.js
Show outdated Hide outdated src/DayPicker.js
@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Mar 8, 2017

Owner

Good idea, thanks – do you feel to add a test as well? 👍

Owner

gpbl commented Mar 8, 2017

Good idea, thanks – do you feel to add a test as well? 👍

@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Mar 8, 2017

Owner

This was run with test, cover, and lint, but if there are other modifications necessary, please let me know.

Weird it didn't catch the lint, did you run the folowing?

npm run lint
Owner

gpbl commented Mar 8, 2017

This was run with test, cover, and lint, but if there are other modifications necessary, please let me know.

Weird it didn't catch the lint, did you run the folowing?

npm run lint
@maxdubrinsky

This comment has been minimized.

Show comment
Hide comment
@maxdubrinsky

maxdubrinsky Mar 8, 2017

Contributor

I did, but apparently I added that after I ran lint the first few times. I can throw a couple tests in, though.

Contributor

maxdubrinsky commented Mar 8, 2017

I did, but apparently I added that after I ran lint the first few times. I can throw a couple tests in, though.

@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Mar 8, 2017

Owner

@maxdubrinsky are you working on this during the next... hours 😊? I'd like to release an update soon 🚀
Otherwise I can deal with it.

Owner

gpbl commented Mar 8, 2017

@maxdubrinsky are you working on this during the next... hours 😊? I'd like to release an update soon 🚀
Otherwise I can deal with it.

@maxdubrinsky

This comment has been minimized.

Show comment
Hide comment
@maxdubrinsky

maxdubrinsky Mar 8, 2017

Contributor

Sorry for the delay, I will be able to push an update in the next hour or so.

Contributor

maxdubrinsky commented Mar 8, 2017

Sorry for the delay, I will be able to push an update in the next hour or so.

@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Mar 8, 2017

Owner

No problem, thanks for your effort ❤️

Owner

gpbl commented Mar 8, 2017

No problem, thanks for your effort ❤️

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 8, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 97c1c2f on maxdubrinsky:master into c9ab28f on gpbl:master.

coveralls commented Mar 8, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 97c1c2f on maxdubrinsky:master into c9ab28f on gpbl:master.

@gpbl gpbl merged commit d4ec272 into gpbl:master Mar 8, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Mar 8, 2017

Owner

Awesome thanks!

Owner

gpbl commented Mar 8, 2017

Awesome thanks!

@maxdubrinsky

This comment has been minimized.

Show comment
Hide comment
@maxdubrinsky

maxdubrinsky Mar 8, 2017

Contributor

Thanks for being so prompt! Saved me a bunch of time and headache

Contributor

maxdubrinsky commented Mar 8, 2017

Thanks for being so prompt! Saved me a bunch of time and headache

@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Mar 9, 2017

Owner

Thanks, published as v5.2.0 🎉

Owner

gpbl commented Mar 9, 2017

Thanks, published as v5.2.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment