New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change week aria role to row #322

Merged
merged 1 commit into from May 3, 2017

Conversation

3 participants
@emplums
Contributor

emplums commented May 3, 2017

Hey all! πŸ‘‹

First off - this module is wonderful! πŸŽ‰ πŸ‘

Just running some accessibility audits on our app over at Buffer - we're using react-day-picker and we're getting a few errors when testing with axe-core! Nothing major, but the Week div should have a role="row" instead of role="gridcell" as it is a child of a role="rowgroup" and has children with role="gridcell"

Current role structure:
Month (grid) β†’ Weekdays & Body (rowgroup) β†’ Week (gridcell)β†’ Day (gridcell)

Proposed role structure:
Month (grid) β†’ Weekdays & Body (rowgroup) β†’ Week (row)β†’ Day (gridcell)

More on the rowgroup role in the Web Accessibility Initiative – Accessible Rich Internet Applications standards: https://www.w3.org/TR/wai-aria/roles#rowgroup

Let me know if you have any questions! 😸 thanks again!

Emily
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls May 3, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 2bd238b on emily-plummer:fix/week-aria-role into 24a61f0 on gpbl:master.

coveralls commented May 3, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 2bd238b on emily-plummer:fix/week-aria-role into 24a61f0 on gpbl:master.

@gpbl gpbl merged commit 76ce952 into gpbl:master May 3, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codeclimate no new or fixed issues
Details
codeclimate/coverage 100%
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl May 3, 2017

Owner

Awesome, thanks πŸ™†πŸ½

Owner

gpbl commented May 3, 2017

Awesome, thanks πŸ™†πŸ½

@emplums

This comment has been minimized.

Show comment
Hide comment
@emplums

emplums May 3, 2017

Contributor

Yay! That was so quick! Thanks @gpbl 😸

Contributor

emplums commented May 3, 2017

Yay! That was so quick! Thanks @gpbl 😸

@gpbl gpbl added the a11y label May 3, 2017

@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl May 3, 2017

Owner

Published as v5.4.2 πŸ€–πŸš€

Owner

gpbl commented May 3, 2017

Published as v5.4.2 πŸ€–πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment