Skip to content

change week aria role to row#322

Merged
gpbl merged 1 commit intogpbl:masterfrom
emplums:fix/week-aria-role
May 3, 2017
Merged

change week aria role to row#322
gpbl merged 1 commit intogpbl:masterfrom
emplums:fix/week-aria-role

Conversation

@emplums
Copy link
Contributor

@emplums emplums commented May 3, 2017

Hey all! 👋

First off - this module is wonderful! 🎉 👍

Just running some accessibility audits on our app over at Buffer - we're using react-day-picker and we're getting a few errors when testing with axe-core! Nothing major, but the Week div should have a role="row" instead of role="gridcell" as it is a child of a role="rowgroup" and has children with role="gridcell"

Current role structure:
Month (grid) → Weekdays & Body (rowgroup) → Week (gridcell)→ Day (gridcell)

Proposed role structure:
Month (grid) → Weekdays & Body (rowgroup) → Week (row)→ Day (gridcell)

More on the rowgroup role in the Web Accessibility Initiative – Accessible Rich Internet Applications standards: https://www.w3.org/TR/wai-aria/roles#rowgroup

Let me know if you have any questions! 😸 thanks again!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2bd238b on emily-plummer:fix/week-aria-role into 24a61f0 on gpbl:master.

@gpbl gpbl merged commit 76ce952 into gpbl:master May 3, 2017
@gpbl
Copy link
Owner

gpbl commented May 3, 2017

Awesome, thanks 🙆🏽

@emplums
Copy link
Contributor Author

emplums commented May 3, 2017

Yay! That was so quick! Thanks @gpbl 😸

@gpbl gpbl added the aria label May 3, 2017
@gpbl
Copy link
Owner

gpbl commented May 3, 2017

Published as v5.4.2 🤖🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants