Bugfix: Better Day.shouldComponentUpdate implementation and exporting… #452
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugs:
Fixes #446
The
Day.shouldComponentUpdatemethod was not allowing days to update when anything other than modifiers changed. This can lead to buggy behavior if many public props of DayPicker change.Also, the NavbarPropTypes and WeekdayPropTypes were being exported incorrectly starting here: 0b5a46f
Changes:
DayPicker.jswhere appropriate.Day, do a shallow compare to determine the return value ofshouldComponentUpdate. However,modifiersandmodifiersStylesneed their own shallow compare as well, so make an exception for them.cc: @gpbl