New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar - fix for disabled interaction in RTL #471

Merged
merged 2 commits into from Aug 6, 2017

Conversation

2 participants
@edoshor
Contributor

edoshor commented Jul 27, 2017

The RTL support in Navbar lacks symmetry when dealing with disabled interaction with the previous and next buttons.

The fix swaps the values of the showPreviousButton and showNextButton props on RTL.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Jul 27, 2017

Codecov Report

Merging #471 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #471   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         527    531    +4     
  Branches      109    109           
=====================================
+ Hits          527    531    +4
Impacted Files Coverage Δ
src/Navbar.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8dc1ce...77c47d8. Read the comment docs.

codecov bot commented Jul 27, 2017

Codecov Report

Merging #471 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #471   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         527    531    +4     
  Branches      109    109           
=====================================
+ Hits          527    531    +4
Impacted Files Coverage Δ
src/Navbar.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8dc1ce...77c47d8. Read the comment docs.

@gpbl gpbl added this to the v6.1.1 milestone Aug 6, 2017

@gpbl gpbl merged commit 09a7eab into gpbl:master Aug 6, 2017

3 checks passed

ci/circleci: checkout-and-test Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (+0%) compared to b8dc1ce
Details
@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Aug 6, 2017

Owner

Thanks! sorry for the delay ✌🏽

Owner

gpbl commented Aug 6, 2017

Thanks! sorry for the delay ✌🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment