New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DayPickerInput check for prop change with previous props rather than previous state #495

Merged
merged 3 commits into from Sep 26, 2017

Conversation

2 participants
@kradical
Contributor

kradical commented Sep 22, 2017

Hello!

I filed this issue: #494.

I have tested this with dayPickerProps and without dayPickerProps.

@kradical kradical changed the title from Check for prop change with previous props rather than state to DayPickerInput check for prop change with previous props rather than previous state Sep 22, 2017

Konrad Schultz
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Sep 22, 2017

Codecov Report

Merging #495 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #495   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         531    534    +3     
  Branches      109    111    +2     
=====================================
+ Hits          531    534    +3
Impacted Files Coverage Δ
src/DayPickerInput.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a4e99b...5959f76. Read the comment docs.

codecov bot commented Sep 22, 2017

Codecov Report

Merging #495 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #495   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         531    534    +3     
  Branches      109    111    +2     
=====================================
+ Hits          531    534    +3
Impacted Files Coverage Δ
src/DayPickerInput.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a4e99b...5959f76. Read the comment docs.

@gpbl

gpbl requested changes Sep 23, 2017 edited

Hey thanks for your PR! I asked you to update the code a bit so we can understand better what's happening there. componentWillReceiveProps is a delicate part of the lifecycle and we want to avoid unforeseen bugs.

Show outdated Hide outdated src/DayPickerInput.js
Show outdated Hide outdated src/DayPickerInput.js
Show outdated Hide outdated src/DayPickerInput.js
@gpbl

gpbl approved these changes Sep 26, 2017

@gpbl gpbl merged commit abffd24 into gpbl:master Sep 26, 2017

3 checks passed

ci/circleci: checkout-and-test Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (+0%) compared to 2a4e99b
Details

@gpbl gpbl added this to the v6.1.1 milestone Sep 26, 2017

@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Sep 26, 2017

Owner

Thanks!

Owner

gpbl commented Sep 26, 2017

Thanks!

@kradical kradical deleted the riipen:prChanges branch Sep 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment