New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added `renderWeek` prop to render a custom element for week box #497

Merged
merged 1 commit into from Oct 10, 2017

Conversation

2 participants
@jenshandersson
Contributor

jenshandersson commented Sep 25, 2017

I needed a way to render a custom element for week boxes on the left.
Following the renderDay implementation I created a renderWeek prop.
It defaults to the current behavior, rendering the weekNumber.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Sep 25, 2017

Codecov Report

Merging #497 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #497   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         534    535    +1     
  Branches      111    111           
=====================================
+ Hits          534    535    +1
Impacted Files Coverage Δ
src/Month.js 100% <ø> (ø) ⬆️
src/DayPicker.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd14401...0d9b76c. Read the comment docs.

codecov bot commented Sep 25, 2017

Codecov Report

Merging #497 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #497   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         534    535    +1     
  Branches      111    111           
=====================================
+ Hits          534    535    +1
Impacted Files Coverage Δ
src/Month.js 100% <ø> (ø) ⬆️
src/DayPicker.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd14401...0d9b76c. Read the comment docs.

@gpbl

Nice @jenshandersson!

Could you please include in the PR only the changes to /src? Docs and built files don't need to be added to the PR: I'll take care of them by myself. Thanks again 👍

@gpbl gpbl added this to the v6.2.0 milestone Sep 27, 2017

@jenshandersson

This comment has been minimized.

Show comment
Hide comment
@jenshandersson

jenshandersson Oct 10, 2017

Contributor

@gpbl I have done what you requested, only committed the source files. Please let me know if you need anything else.

Contributor

jenshandersson commented Oct 10, 2017

@gpbl I have done what you requested, only committed the source files. Please let me know if you need anything else.

@gpbl gpbl merged commit 83b1057 into gpbl:master Oct 10, 2017

3 checks passed

ci/circleci: checkout-and-test Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (+0%) compared to bd14401
Details
@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Oct 10, 2017

Owner

Awesome thanks!!

Owner

gpbl commented Oct 10, 2017

Awesome thanks!!

@jenshandersson

This comment has been minimized.

Show comment
Hide comment
@jenshandersson

jenshandersson Oct 12, 2017

Contributor

Thanks for merging in @gpbl! Will you have time to rebuild and update the patch version?

Contributor

jenshandersson commented Oct 12, 2017

Thanks for merging in @gpbl! Will you have time to rebuild and update the patch version?

@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Oct 12, 2017

Owner

@jenshandersson I’m going to cut a minor release in the next days 👍🏽 thanks for your patience!

Owner

gpbl commented Oct 12, 2017

@jenshandersson I’m going to cut a minor release in the next days 👍🏽 thanks for your patience!

@gpbl gpbl modified the milestones: v6.2.0, v6.3.0 Oct 14, 2017

@gpbl gpbl modified the milestones: v6.3.0, v7.0.0 Nov 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment