/react-day-picker

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix modifiers when using classNames #517

Closed
wants to merge 1 commit into
base: master
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
bug:minor src:DayPickerInput
Projects
None yet
Milestone
No milestone
2 participants
@gpbl @kuldarim
@gpbl
Copy link
Owner

gpbl commented Oct 15, 2017

Replace #504

@gpbl gpbl added bug:minor src:DayPickerInput labels Oct 15, 2017

@gpbl gpbl added this to the v6.3.0 milestone Oct 15, 2017

@codecov

This comment has been minimized.

Sign in to view
Copy link

codecov bot commented Oct 15, 2017

Codecov Report

Merging #517 into master will decrease coverage by 0.36%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #517      +/-   ##
==========================================
- Coverage     100%   99.63%   -0.37%     
==========================================
  Files          15       15              
  Lines         540      547       +7     
  Branches      113      115       +2     
==========================================
+ Hits          540      545       +5     
- Misses          0        2       +2
Impacted Files Coverage Δ
src/DayPickerInput.js 98.19% <86.66%> (-1.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7e5cd4...bdefb75. Read the comment docs.
@codecov

This comment has been minimized.

Sign in to view
Copy link

codecov bot commented Oct 15, 2017

Codecov Report

Merging #517 into master will decrease coverage by 0.36%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #517      +/-   ##
==========================================
- Coverage     100%   99.63%   -0.37%     
==========================================
  Files          15       15              
  Lines         540      547       +7     
  Branches      113      115       +2     
==========================================
+ Hits          540      545       +5     
- Misses          0        2       +2
Impacted Files Coverage Δ
src/DayPickerInput.js 98.19% <86.66%> (-1.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7e5cd4...bdefb75. Read the comment docs.

@gpbl gpbl referenced this pull request Oct 15, 2017

Closed

Fix modifiers when using cssmodules #504

@gpbl gpbl modified the milestones: v6.3.0, v7.0.0 Nov 25, 2017

@gpbl gpbl removed this from the v7.0.0 milestone Dec 31, 2017

@kuldarim

This comment has been minimized.

Sign in to view
Copy link

kuldarim commented Feb 21, 2018

@gpbl are you planning to merge this at some point?
@gpbl

This comment has been minimized.

Sign in to view
Copy link
Owner Author

gpbl commented Feb 22, 2018 •
edited

@kuldarim we need to fix tests and conflicts. Would you mind to open a new PR to replace this one? 🙏

@gpbl gpbl referenced this pull request Apr 8, 2018

Closed

Fix modifiers when using classNames #690

@gpbl

This comment has been minimized.

Sign in to view
Copy link
Owner Author

gpbl commented Apr 14, 2018

Replaced by #690

@gpbl gpbl closed this Apr 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment