New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't overrides DayPickerInput selectedDays prop #531

Merged
merged 3 commits into from Nov 5, 2017

Conversation

2 participants
@hydrognomik
Contributor

hydrognomik commented Oct 26, 2017

This PR for #521. dayPickerProps moved after selectedDays so DayPickerInput's selectedDays won't be overridden.

@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Oct 26, 2017

Owner

Thanks for the PR! Wondering why tests are failing here 🤔

Owner

gpbl commented Oct 26, 2017

Thanks for the PR! Wondering why tests are failing here 🤔

@gpbl gpbl added this to the v6.3.0 milestone Oct 31, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Nov 1, 2017

Codecov Report

Merging #531 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #531   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         541    553   +12     
  Branches      113    117    +4     
=====================================
+ Hits          541    553   +12
Impacted Files Coverage Δ
src/DayPickerInput.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90040fc...132c4b2. Read the comment docs.

codecov bot commented Nov 1, 2017

Codecov Report

Merging #531 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #531   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         541    553   +12     
  Branches      113    117    +4     
=====================================
+ Hits          541    553   +12
Impacted Files Coverage Δ
src/DayPickerInput.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90040fc...132c4b2. Read the comment docs.

Show outdated Hide outdated test/daypickerinput/rendering.js Outdated
@gpbl

Hey thanks for the updated and for adding a test 🙇 ! I have a comment tough :)

Show outdated Hide outdated test/daypickerinput/rendering.js Outdated

hydrognomik added some commits Nov 4, 2017

@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Nov 5, 2017

Owner

Awesome thanks a lot !

Owner

gpbl commented Nov 5, 2017

Awesome thanks a lot !

@gpbl gpbl merged commit ae71a0c into gpbl:master Nov 5, 2017

3 checks passed

ci/circleci: checkout-and-test Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (+0%) compared to 90040fc
Details

@hydrognomik hydrognomik deleted the hydrognomik:selecteddays branch Nov 7, 2017

@gpbl gpbl modified the milestones: v6.3.0, v7.0.0 Nov 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment