New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed render of months when toMonth and numberOfMonth are passed #556

Merged
merged 1 commit into from Nov 24, 2017

Conversation

3 participants
@hydrognomik
Contributor

hydrognomik commented Nov 20, 2017

This PR for #543. In case when toMonth and numberOfMonth are passed to DayPicker and toMonth earlier or equals currentMonth moves currentMonth so toMonth rendered last.

@hydrognomik hydrognomik changed the title from Fixed render of months #543 to Fixed render of months when toMonth and numberOfMonth are passed Nov 20, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Nov 20, 2017

Codecov Report

Merging #556 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #556   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         558    562    +4     
  Branches      118    120    +2     
=====================================
+ Hits          558    562    +4
Impacted Files Coverage Δ
src/DayPicker.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 567e87e...355f861. Read the comment docs.

codecov bot commented Nov 20, 2017

Codecov Report

Merging #556 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #556   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         558    562    +4     
  Branches      118    120    +2     
=====================================
+ Hits          558    562    +4
Impacted Files Coverage Δ
src/DayPicker.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 567e87e...355f861. Read the comment docs.

@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Nov 23, 2017

Owner

Thanks again!! I think we should add a test case for it :)

@hydrognomik do you have the time for this while I'm closing the other issues for the v6.3 release?

Owner

gpbl commented Nov 23, 2017

Thanks again!! I think we should add a test case for it :)

@hydrognomik do you have the time for this while I'm closing the other issues for the v6.3 release?

@hydrognomik

This comment has been minimized.

Show comment
Hide comment
@hydrognomik

hydrognomik Nov 23, 2017

Contributor

Yes, sure.

Contributor

hydrognomik commented Nov 23, 2017

Yes, sure.

@gpbl gpbl merged commit 33530cb into gpbl:master Nov 24, 2017

3 checks passed

ci/circleci: checkout-and-test Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (+0%) compared to 567e87e
Details

@gpbl gpbl added this to the v6.3.0 milestone Nov 24, 2017

@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Nov 24, 2017

Owner

Thanks @hydrognomik for the help! You are great!

Owner

gpbl commented Nov 24, 2017

Thanks @hydrognomik for the help! You are great!

@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Nov 25, 2017

Owner

Published in v7!

Owner

gpbl commented Nov 25, 2017

Published in v7!

@leojh

This comment has been minimized.

Show comment
Hide comment
@leojh

leojh Dec 19, 2017

Verified!

leojh commented Dec 19, 2017

Verified!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment