New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to disable roll to prev/next month if outside day is clicked #585

Merged
merged 2 commits into from Mar 4, 2018

Conversation

3 participants
@smesgr
Contributor

smesgr commented Dec 8, 2017

Some of my users have difficulties to understand the outside click feature.
If only one month is visible it seems to be ok, but if more then one month is rendered they find it confusing.

Thus I would like to disable this feature.
With new property name I'm unhappy, but can't come up with a more precise phrase.

@codecov

This comment has been minimized.

codecov bot commented Dec 8, 2017

Codecov Report

Merging #585 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #585   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         609    609           
  Branches      129    129           
=====================================
  Hits          609    609
Impacted Files Coverage Δ
src/DayPicker.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f27211f...1f0715d. Read the comment docs.

@gpbl

This comment has been minimized.

Owner

gpbl commented Dec 8, 2017

Thanks for you contribution! Yep we could call that prop enableOutsideDaysClick.

@smesgr

This comment has been minimized.

Contributor

smesgr commented Dec 11, 2017

yeah your suggestion sounds better then mine. 👍

@gpbl gpbl added this to the v7.1.0 milestone Feb 23, 2018

@gpbl gpbl added the v:minor label Feb 23, 2018

@gpbl gpbl removed this from the v7.1.0 milestone Feb 23, 2018

@ebrillhart

This comment has been minimized.

ebrillhart commented Feb 27, 2018

@gpbl Chiming in to say I'd love to have this merged - have a project where we'd like users to be able to see/select full weeks even if they fall between months, but don't want the month to change on click. Is there a timeline for merging and releasing this functionality? Happy to chip in with some help if that would hasten it along!

@gpbl gpbl merged commit b7051d2 into gpbl:master Mar 4, 2018

3 checks passed

ci/circleci: checkout-and-test Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (+0%) compared to f27211f
Details

@gpbl gpbl added this to the v7.1.0 milestone Mar 5, 2018

@gpbl

This comment has been minimized.

Owner

gpbl commented Mar 5, 2018

Published as v7.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment