Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disabledDays not working using classNames #741

Merged
merged 2 commits into from Jul 7, 2018

Conversation

Projects
None yet
3 participants
@hannescalibrate
Copy link
Contributor

hannescalibrate commented Jun 21, 2018

I added an extra check on the handleDayClick so it also checks the classNames next to the modifiers.

Closes #689

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jun 21, 2018

Codecov Report

Merging #741 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #741   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         645    645           
  Branches      140    140           
=====================================
  Hits          645    645
Impacted Files Coverage Δ
src/DayPickerInput.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31d0ea6...380acea. Read the comment docs.

@ethanve

This comment has been minimized.

Copy link

ethanve commented Jun 28, 2018

@gpbl can we merge this in? I'm sorely in need of this fix

@gpbl gpbl added the v:patch label Jul 7, 2018

@gpbl gpbl changed the title Added extra check in dayclick. Fix disabledDays not working using classNames Jul 7, 2018

@gpbl gpbl merged commit 76dc3aa into gpbl:master Jul 7, 2018

3 checks passed

ci/circleci: checkout-and-test Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (+0%) compared to 31d0ea6
Details
@gpbl

This comment has been minimized.

Copy link
Owner

gpbl commented Jul 7, 2018

Sure, sorry for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.