Skip to content

Fix wrong type definition on LocaleUtils#828

Merged
gpbl merged 1 commit intogpbl:masterfrom
lukyth:lukyth/fix-types
Feb 21, 2019
Merged

Fix wrong type definition on LocaleUtils#828
gpbl merged 1 commit intogpbl:masterfrom
lukyth:lukyth/fix-types

Conversation

@lukyth
Copy link
Contributor

@lukyth lukyth commented Nov 13, 2018

Every locale has en as the default value so they're optional. Source: https://github.com/gpbl/react-day-picker/blob/master/src/addons/MomentLocaleUtils.js#L5

Every `locale` has `en` as the default value so they're optional.
@codecov
Copy link

codecov bot commented Nov 13, 2018

Codecov Report

Merging #828 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #828   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         645    645           
  Branches      141    141           
=====================================
  Hits          645    645

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39ad48e...456ee0c. Read the comment docs.

@gpbl gpbl merged commit f8a36a0 into gpbl:master Feb 21, 2019
@gpbl
Copy link
Owner

gpbl commented Feb 21, 2019

Awesome, thanks!

@lukyth lukyth deleted the lukyth/fix-types branch February 21, 2019 08:36
kimamula pushed a commit to kimamula/react-day-picker that referenced this pull request Aug 17, 2022
Every `locale` has `en` as the default value so they're optional.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants