Skip to content

Conversation

@johnjesse
Copy link
Contributor

Fix for #837:

Basically, it used the dir prop to decide how to handle the left and right arrows being pressed, switching what they do in RTL.

I've also added the missing dir prop to the DayPickerProps interface.

The docs for dir usage are missing right now... it would be good to add them, I'd be happy to do that as part of this PR - although the PR template warns against making any changes to the docs

@codecov
Copy link

codecov bot commented Dec 12, 2018

Codecov Report

Merging #845 into master will decrease coverage by 0.61%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #845      +/-   ##
==========================================
- Coverage     100%   99.38%   -0.62%     
==========================================
  Files          15       15              
  Lines         645      653       +8     
  Branches      141      145       +4     
==========================================
+ Hits          645      649       +4     
- Misses          0        4       +4
Impacted Files Coverage Δ
src/DayPicker.js 97.7% <66.66%> (-2.3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39ad48e...3a892a7. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Dec 12, 2018

Codecov Report

Merging #845 into master will decrease coverage by 0.61%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #845      +/-   ##
==========================================
- Coverage     100%   99.38%   -0.62%     
==========================================
  Files          15       15              
  Lines         645      653       +8     
  Branches      141      145       +4     
==========================================
+ Hits          645      649       +4     
- Misses          0        4       +4
Impacted Files Coverage Δ
src/DayPicker.js 97.7% <66.66%> (-2.3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39ad48e...3a892a7. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 12, 2018

Codecov Report

Merging #845 into master will decrease coverage by 0.61%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #845      +/-   ##
==========================================
- Coverage     100%   99.38%   -0.62%     
==========================================
  Files          15       15              
  Lines         645      653       +8     
  Branches      141      145       +4     
==========================================
+ Hits          645      649       +4     
- Misses          0        4       +4
Impacted Files Coverage Δ
src/DayPicker.js 97.7% <66.66%> (-2.3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39ad48e...3a892a7. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 12, 2018

Codecov Report

Merging #845 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #845   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         645    653    +8     
  Branches      141    145    +4     
=====================================
+ Hits          645    653    +8
Impacted Files Coverage Δ
src/DayPicker.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39ad48e...260a11f. Read the comment docs.

@gpbl
Copy link
Owner

gpbl commented Feb 21, 2019

Awesome, thank you – sorry for being so late on this!

@gpbl gpbl merged commit 072e305 into gpbl:master Feb 21, 2019
@gpbl gpbl added the v:minor label Feb 21, 2019
kimamula pushed a commit to kimamula/react-day-picker that referenced this pull request Aug 17, 2022
* Switch what left and right keys do in RTL

Also add missing type of dir prop on DayPicker

* Fix linting error

* Add unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants