-
-
Notifications
You must be signed in to change notification settings - Fork 761
Switch what left and right keys do in RTL #845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also add missing type of dir prop on DayPicker
Codecov Report
@@ Coverage Diff @@
## master #845 +/- ##
==========================================
- Coverage 100% 99.38% -0.62%
==========================================
Files 15 15
Lines 645 653 +8
Branches 141 145 +4
==========================================
+ Hits 645 649 +4
- Misses 0 4 +4
Continue to review full report at Codecov.
|
2 similar comments
Codecov Report
@@ Coverage Diff @@
## master #845 +/- ##
==========================================
- Coverage 100% 99.38% -0.62%
==========================================
Files 15 15
Lines 645 653 +8
Branches 141 145 +4
==========================================
+ Hits 645 649 +4
- Misses 0 4 +4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #845 +/- ##
==========================================
- Coverage 100% 99.38% -0.62%
==========================================
Files 15 15
Lines 645 653 +8
Branches 141 145 +4
==========================================
+ Hits 645 649 +4
- Misses 0 4 +4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #845 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 15 15
Lines 645 653 +8
Branches 141 145 +4
=====================================
+ Hits 645 653 +8
Continue to review full report at Codecov.
|
|
Awesome, thank you – sorry for being so late on this! |
* Switch what left and right keys do in RTL Also add missing type of dir prop on DayPicker * Fix linting error * Add unit tests
Fix for #837:
Basically, it used the dir prop to decide how to handle the left and right arrows being pressed, switching what they do in RTL.
I've also added the missing
dirprop to theDayPickerPropsinterface.The docs for dir usage are missing right now... it would be good to add them, I'd be happy to do that as part of this PR - although the PR template warns against making any changes to the docs