New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing Enter on the keyboard should trigger Generate/Regenerate button #11

Closed
GoogleCodeExporter opened this Issue Jun 26, 2015 · 2 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter

GoogleCodeExporter commented Jun 26, 2015

In Issue 9, hyptristis included the following additional request, which should 
technically be pulled out into a separate enhancement:

"On my device, pressing 'Enter' (either from on-screen soft keyboard or 
physical keyboard) within the master password box will generate one more 
asterisk (hidden master password), or generates a new line (visible master 
password). Could you make it regenerate password upon pressing 'Enter'? I think 
this would be the most convenient way!"

It should be possible to implement this, and it would be more consistent with 
the Windows client, which already does the same thing. With the Windows client, 
this was pretty simple; Windows forms have a concept of "default buttons" that 
get "pressed" when certain buttons are pressed. For example, hitting Escape 
often triggers the "close" functionality, while Enter triggers the most common 
task. In Cryptnos for Windows, pressing Enter triggers the Generate button 
which (re)generates the password for the currently selected site.

This is a little more difficult in Android as it doesn't have the concept of a 
default action like this. However, it's possible to attach a key event trigger 
to the master password text box and scan each character entered for the Enter 
key. If the Enter key is encountered, it should not be added to the master 
password string but should instead trigger the Regenerate or Generate button on 
the screen (or, more properly, the event listener method attached to that 
button).

I experimented with this once for a different feature but had a little bit of 
trouble getting it to work (which is why that feature hasn't been released yet 
:D ). I still think it's possible, but I think I wasn't doing something quite 
the way I was supposed to so it didn't work.

I'll go ahead and add this into the to-do list for 1.3.1 as I don't think it 
will be too difficult and it's something that's been bugging me as well.

Original issue reported on code.google.com by jeff.darlington@gmail.com on 29 Mar 2012 at 2:55

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Jun 26, 2015

Implemented with Revision 64

Original comment by jeff.darlington@gmail.com on 29 Mar 2012 at 8:33

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Jun 26, 2015

Released with Version 1.3.1

Original comment by jeff.darlington@gmail.com on 16 Apr 2012 at 2:41

  • Changed state: Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment