This repository has been archived by the owner on Sep 21, 2020. It is now read-only.
GPII-3412 - Improve the GCP/README.md #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrtyler
reviewed
Oct 8, 2018
gcp/README.md
Outdated
| 1. `cd gpii-infra/gcp/live/dev` | ||
| 1. `rake` | ||
| 1. If it's the first time that you deploy the infrastructure you will be prompted to verify your identity at Google and allow permissions to your applications to perform modifications in your personal project at GCP. Go to the url shown and copy and paste the token once the application is authorized. | ||
| 1. Once finished all the GPII endpoints should be available at https://<service>.<your cluster name>.dev.gcp.gpii.net/ |
There was a problem hiding this comment.
I would add an example here to illustrate: "should be available at https://XXX, e.g. https://flowmanager.amatas.dev.gcp.gpii.net/".
gcp/README.md
Outdated
| 1. `cd gpii-infra/gcp/live/dev` | ||
| 1. `rake` | ||
| 1. If it's the first time that you deploy the infrastructure you will be prompted to verify your identity at Google and allow permissions to your applications to perform modifications in your personal project at GCP. Go to the url shown and copy and paste the token once the application is authorized. | ||
| 1. Once finished all the GPII endpoints should be available at https://<service>.<your cluster name>.dev.gcp.gpii.net/ | ||
| 1. The dashboard is available through the [Google Cloud Console](https://console.cloud.google.com) |
There was a problem hiding this comment.
There's a lot of stuff on the Console landing page. I would try to provide a more specific link.
gcp/README.md
Outdated
| 1. Once finished all the GPII endpoints should be available at https://<service>.<your cluster name>.dev.gcp.gpii.net/ | ||
| 1. The dashboard is available through the [Google Cloud Console](https://console.cloud.google.com) | ||
|
|
||
| ## |
|
looks good |
amatas
force-pushed
the
GPII-3412
branch
3 times, most recently
from
de91509
to
f61dca4
Compare
|
I've also added a section dedicated to the Google Cloud Console that can be useful for the people. |
|
LGTM |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some notes that can help to the developers in the use of the new infrastructure built on top of GCP.
Rendered README.md