Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPII-3832: Handle production configuration tests in GPC and AWS #347

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@klown
Copy link

commented Apr 4, 2019

JIRA: https://issues.gpii.net/browse/GPII-3832

@mrtyler,
These changes are for AWS, where the code to run the production tests has been removed.

Technically, this modification is a result of the changes in the pull request for GPII-3333 and could wait until that PR is merged into universal master. However, since this just removes the execution of the tests from a rakefile, it could go anytime. I leave it to you.

And, if you see anything untoward here, let me know.

klown added some commits Mar 29, 2019

@mrtyler

This comment has been minimized.

Copy link

commented Apr 4, 2019

LGTM.

It's weird that this task never seems to be called. It doesn't look like it was called in @cindyli's PR that added the task https://github.com/gpii-ops/gpii-infra/pull/29/files. Maybe we had a reason for this, or maybe it was an oversight (maybe Cindy remembers)?

My understanding is that this task won't work once your changes for GPII-3333 are merged, so either way removing this task is the right move.

@amatas

This comment has been minimized.

Copy link

commented Apr 5, 2019

LGTM

@stepanstipl

This comment has been minimized.

Copy link

commented Apr 5, 2019

lgtm

@klown

This comment has been minimized.

Copy link
Author

commented Apr 8, 2019

@mrtyler wrote:

My understanding is that this task won't work once your changes for GPII-3333 are merged, so either way removing this task is the right move

Two comments, one simple and the other a little more involved:

  1. Currently, the command run in the container is node tests/ProductionConfigTests.js. The script file ProductionConfigTests.js no longer exists in GPII-3333 due to refactoring and re-use of a number of other already-defined tests. But, that could be replaced by the latest command: npm run test:productionConfig.
  2. There is a pre-load and post-clear of the Couch database that adds/removes GPII keys and PrefsSafes to use by the production tests. This is done using direct requests to Couch , e.g., a POST request such as "https://couchdb:5984/gpii" sending a GPII key as the payload.

Regarding 2, it works fine in a Vagrant VM context, but likely needs more in a cloud development environment, such as authorization for these database requests. Furthermore, as discussed at the 27-Mar teleconference, it's not a good idea to be modifying the database in prd, and probably not even in stg. My current thought is that the target is only the dev-$USER environment.

@cindyli

This comment has been minimized.

Copy link

commented Apr 22, 2019

@mrtyler was right that the task "wait_for_productionConfigTests_complete" was never called. I guess I was focus on getting "wait_for_gpii_ready" task run and missed including this task. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.