Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
GPII-3832: Handle production configuration tests in GPC and AWS #347
Technically, this modification is a result of the changes in the pull request for GPII-3333 and could wait until that PR is merged into universal master. However, since this just removes the execution of the tests from a rakefile, it could go anytime. I leave it to you.
And, if you see anything untoward here, let me know.
It's weird that this task never seems to be called. It doesn't look like it was called in @cindyli's PR that added the task https://github.com/gpii-ops/gpii-infra/pull/29/files. Maybe we had a reason for this, or maybe it was an oversight (maybe Cindy remembers)?
My understanding is that this task won't work once your changes for GPII-3333 are merged, so either way removing this task is the right move.
Two comments, one simple and the other a little more involved:
Regarding 2, it works fine in a Vagrant VM context, but likely needs more in a cloud development environment, such as authorization for these database requests. Furthermore, as discussed at the 27-Mar teleconference, it's not a good idea to be modifying the database in prd, and probably not even in stg. My current thought is that the target is only the dev-$USER environment.