Warn users when using default pin factory for Servos and Distance Sensors, close #780 #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @SofiiaKosovan! Assigning to @waveform80 to review this |
lurch
reviewed
Jul 13, 2019
| "Warning raised when falling back to the software implementation" | ||
| "Warning raised when falling back to the SPI software implementation" | ||
|
|
||
| class PWMSoftwareFallback(SPIWarning): |
There was a problem hiding this comment.
I'm not sure if it (logically) makes sense for PWMSoftwareFallback to be a subclass of SPIWarning ? 🤷♂️
lurch
reviewed
Jul 13, 2019
| if PiGPIOFactory is None or not isinstance(self.pin_factory, PiGPIOFactory): | ||
| warnings.warn(PWMSoftwareFallback( | ||
| 'To reduce servo jitter, use the pigpio pin factory.' | ||
| 'See https://gpiozero.readthedocs.io/en/stable/api_output.html#servo for more info' |
There was a problem hiding this comment.
It seems that the documentation being pointed to doesn't mention PiGpio at all? Maybe this PR should also update the associated documentation?
There was a problem hiding this comment.
A note was added to the Servo docstring in this PR :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#780