This repository has been archived by the owner on Jul 17, 2020. It is now read-only.
Nginx init.d script not filtering out comments correctly when awk-ing for the PID #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en awk-ing for the PID.
gplessis
pushed a commit
that referenced
this pull request
Apr 27, 2013
Nginx init.d script not filtering out comments correctly when awk-ing for the PID (Thanks @tjasko)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you declare the PID file in /etc/nginx/nginx.conf file like this:
The code (
PID=$(awk -F'[ ;]' '/[^#]pid/ {print $2}' /etc/nginx/nginx.conf)) getting the PID will include the comment (even though it excludes all other comments) making$PIDoutput as follows:I changed the variable to be set with
awk -F'[ ;]' '$1 !~ /^#/ && /pid/ {print $2}' /etc/nginx/nginx.confand now it is working correctly when someone includes "pid" in any comment above.