New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to inner workings on how YouTube video formats are handled + GUI for video quality switch #19

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@Chionsas
Contributor

Chionsas commented Sep 19, 2012

This pull request introduces changes to YouTube video format selection when default preferred format is unavailable and gives a GUI switch to select a preferred video quality.
More info can be found in the commit message :)

@thp

This comment has been minimized.

Show comment
Hide comment
@thp

thp Sep 21, 2012

Member

Thank you for your pull request. I've added some comments to the commit - can you integrate the suggestions into your patch and submit an updated pull request? If any of my comments are unclear, please feel free to ask and I'll explain.

Member

thp commented Sep 21, 2012

Thank you for your pull request. I've added some comments to the commit - can you integrate the suggestions into your patch and submit an updated pull request? If any of my comments are unclear, please feel free to ask and I'll explain.

@thp

This comment has been minimized.

Show comment
Hide comment
@thp

thp Oct 1, 2012

Member

I've noticed that you commit doesn't have a proper name and e-mail address attached to it. Please set it up as described in http://git-scm.com/book/en/Getting-Started-First-Time-Git-Setup and send me your name and e-mail address, so that your contributions are properly attributed in the Git history.

Member

thp commented Oct 1, 2012

I've noticed that you commit doesn't have a proper name and e-mail address attached to it. Please set it up as described in http://git-scm.com/book/en/Getting-Started-First-Time-Git-Setup and send me your name and e-mail address, so that your contributions are properly attributed in the Git history.

@thp

This comment has been minimized.

Show comment
Hide comment
@thp

thp Oct 1, 2012

Member

I've uploaded a cleaned up version of your patch here, please take a look and tell me if this works for you:

https://github.com/gpodder/gpodder/tree/pull19

Member

thp commented Oct 1, 2012

I've uploaded a cleaned up version of your patch here, please take a look and tell me if this works for you:

https://github.com/gpodder/gpodder/tree/pull19

Chionsas and others added some commits Sep 19, 2012

Chionsas
YouTube: Gtk UI for video quality selection (pull request 19)
1) Redid the youtube video format list (added fallbacks for each quality
setting) and added a new config key youtube.preferred_format_ids, that
accepts a list of supported quality ids.

2) Added a GUI setting switcher that lets a user pick between predefined
video quality settings and respects the 'custom' setting.  'Custom'
should currently only be used if the user prefers 3D formats or 3GP.
All other variants are in the normal settings with sane fallbacks.

Existing users will not feel any change (current fmt=18 default is
respected). Only the default fallback for get_real_download_url() was
changed (to 720p), but that will never be called unless the user clears
her youtube.preferred_fmt_id variable.
@Chionsas

This comment has been minimized.

Show comment
Hide comment
@Chionsas

Chionsas Oct 13, 2012

Contributor

Yup, that works. Thanks!
I've set up my name as "Chionsas" and email as "github@chionsas.lt". No need for credit, though ;)

Contributor

Chionsas commented Oct 13, 2012

Yup, that works. Thanks!
I've set up my name as "Chionsas" and email as "github@chionsas.lt". No need for credit, though ;)

@thp

This comment has been minimized.

Show comment
Hide comment
@thp

thp Oct 23, 2012

Member

Thanks, the two commits have now been merged, and I've updated your name and e-mail in the commit.

Member

thp commented Oct 23, 2012

Thanks, the two commits have now been merged, and I've updated your name and e-mail in the commit.

@thp thp closed this Oct 23, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment