New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device sync: add option to disable sync for specific channels #22

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@schaal
Contributor

schaal commented Oct 3, 2012

This is based on a previous patch by Rafi Rubin (rafiyr@b067bd) and incorporates the suggestions from the mailing list (http://www.freelists.org/post/gpodder/device-sync-perchannel-settings,1), namely it bumps the schema version to 4 and adds sql upgrade instructions. It also renames the column to sync_enabled and uses the value from a gpodder2 db when upgrading.

@thp

This comment has been minimized.

Show comment
Hide comment
@thp

thp Oct 23, 2012

Member

Thanks for your patch - can you please rebase it on top of the current Git master branch?

Member

thp commented Oct 23, 2012

Thanks for your patch - can you please rebase it on top of the current Git master branch?

@schaal

This comment has been minimized.

Show comment
Hide comment
@schaal

schaal Oct 23, 2012

Contributor

No problem, I have just pushed an updated version of the patch against current master.

Contributor

schaal commented Oct 23, 2012

No problem, I have just pushed an updated version of the patch against current master.

@thp

This comment has been minimized.

Show comment
Hide comment
@thp

thp Oct 24, 2012

Member

Looking quite good already! I've added some comments where I think we could improve this patch before merging it. Feel free to discuss any points that you disagree with or for which you have even better suggestions.

Member

thp commented Oct 24, 2012

Looking quite good already! I've added some comments where I think we could improve this patch before merging it. Feel free to discuss any points that you disagree with or for which you have even better suggestions.

Device sync: added a sync_enabled to channel
Per-channel sync pause/disable, bump schema version for
new column.

Based on work by Rafi Rubin <rafi@seas.upenn.edu>
@schaal

This comment has been minimized.

Show comment
Hide comment
@schaal

schaal Oct 26, 2012

Contributor

Just pushed an updated patch implementing your suggestions.

Contributor

schaal commented Oct 26, 2012

Just pushed an updated patch implementing your suggestions.

@thp

This comment has been minimized.

Show comment
Hide comment
@thp

thp Nov 3, 2012

Member

Patch merged, thanks for your contribution!
Related bug fixed: http://gpodder.org/bug/1637

Member

thp commented Nov 3, 2012

Patch merged, thanks for your contribution!
Related bug fixed: http://gpodder.org/bug/1637

@thp thp closed this Nov 3, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment