New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid python-3.7 reserved keyword "async" #487

Merged
merged 1 commit into from Jun 26, 2018

Conversation

Projects
None yet
2 participants
@tmzullinger
Contributor

tmzullinger commented Jun 25, 2018

The "async" keyword was added in python-3.7¹. Using it throws
SyntaxError exception.

¹ https://docs.python.org/3.7/whatsnew/3.7.html
https://bugs.python.org/issue30406

Avoid python-3.7 reserved keyword "async"
The "async" keyword was added in python-3.7¹.  Using it throws
SyntaxError exception.

¹ https://docs.python.org/3.7/whatsnew/3.7.html
  https://bugs.python.org/issue30406

@elelay elelay merged commit 2edf967 into gpodder:master Jun 26, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@elelay

This comment has been minimized.

Show comment
Hide comment
@elelay

elelay Jun 26, 2018

Member

Merged, thanks!
Does gPodder otherwise run under python 3.7?

Member

elelay commented Jun 26, 2018

Merged, thanks!
Does gPodder otherwise run under python 3.7?

@tmzullinger

This comment has been minimized.

Show comment
Hide comment
@tmzullinger

tmzullinger Jun 30, 2018

Contributor

Sorry for the delayed reply. I don't know if gPodder has any other issues with python-3.7, unfortunately. But once the current python-3.7 rebuild in fedora's rawhide branch is completed, it should be easier to test. Thanks.

Contributor

tmzullinger commented Jun 30, 2018

Sorry for the delayed reply. I don't know if gPodder has any other issues with python-3.7, unfortunately. But once the current python-3.7 rebuild in fedora's rawhide branch is completed, it should be easier to test. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment