New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the notification extension mandatory on Windows #72

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@smunkel
Contributor

smunkel commented Feb 19, 2013

Right now the non Windows version is mandatory, so this changes that for the windows version. Because the windows version of the notification extension creates an icon in the system tray, this patch also disables the status icon extension for Windows.

@thp

This comment has been minimized.

Show comment
Hide comment
@thp

thp Mar 27, 2013

Member

Merged, thanks: http://gpodder.org/commit/6b87dd77

What happens when the user doesn't have pywintypes or win32gui installed?
Are there cases where the user might want to disable the notification extension?

Member

thp commented Mar 27, 2013

Merged, thanks: http://gpodder.org/commit/6b87dd77

What happens when the user doesn't have pywintypes or win32gui installed?
Are there cases where the user might want to disable the notification extension?

@smunkel

This comment has been minimized.

Show comment
Hide comment
@smunkel

smunkel Mar 27, 2013

Contributor

It will fail silently (unless you could the log). As for disabling the notifications, Windows itself has the tools to handle notifications and icons for applications so that should be sufficient.

Contributor

smunkel commented Mar 27, 2013

It will fail silently (unless you could the log). As for disabling the notifications, Windows itself has the tools to handle notifications and icons for applications so that should be sufficient.

@thp

This comment has been minimized.

Show comment
Hide comment
@thp

thp Mar 27, 2013

Member

Fail silently means that the user doesn't get an error message (except for the log, which is okay), and gPodder still works as if the extension would be disabled, right? If Windows has support for disabling notifications and icons, that's great - nothing left to do there. Thanks again for the patch :)

Member

thp commented Mar 27, 2013

Fail silently means that the user doesn't get an error message (except for the log, which is okay), and gPodder still works as if the extension would be disabled, right? If Windows has support for disabling notifications and icons, that's great - nothing left to do there. Thanks again for the patch :)

@thp thp closed this Mar 27, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment