New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tell user the episode was added to the playlist #94

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
@rigo
Contributor

rigo commented Apr 14, 2013

No description provided.

@thp

This comment has been minimized.

Show comment
Hide comment
@thp

thp Apr 23, 2013

Please avoid whitespace changes :)

Please avoid whitespace changes :)

@thp

This comment has been minimized.

Show comment
Hide comment
@thp

thp Apr 23, 2013

Looks good. I'd change the string to simply read:

Episode added to playlist

This is easier to read for a notification and makes the point clear just as much.

Looks good. I'd change the string to simply read:

Episode added to playlist

This is easier to read for a notification and makes the point clear just as much.

@thp

This comment has been minimized.

Show comment
Hide comment
@thp

thp Apr 23, 2013

Member

Thanks for this patch. See the comments for things that still need changing before this can go in. Please submit an updated patch addressing these issues, then it can go in.

Member

thp commented Apr 23, 2013

Thanks for this patch. See the comments for things that still need changing before this can go in. Please submit an updated patch addressing these issues, then it can go in.

@rigo

This comment has been minimized.

Show comment
Hide comment
@rigo

rigo Apr 24, 2013

Contributor

Done!

Contributor

rigo commented Apr 24, 2013

Done!

@thp

This comment has been minimized.

Show comment
Hide comment
Member

thp commented Apr 24, 2013

@thp thp closed this Apr 24, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment