New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Atom updated dates overriding published #17

Merged
merged 2 commits into from Feb 8, 2018

Conversation

Projects
None yet
2 participants
@romlok
Contributor

romlok commented Feb 5, 2018

This should prevent using erroneous dates when an episode's <updated> comes after its <published> in the XML (gpodder/gpodder#394).

This has been done by adding an overwrite arg to the Target base class, which is then implemented by EpisodeAttr. The argument could also be used by other Target subclasses if needed in future.

@thp

This comment has been minimized.

Member

thp commented Feb 5, 2018

@thp

thp approved these changes Feb 8, 2018

Ok.

@thp thp merged commit ca8849f into gpodder:master Feb 8, 2018

aszlig added a commit to openlab-aux/vuizvui that referenced this pull request Feb 18, 2018

dnyarri: Use latest master for podcastparser
Seems that 543ca65 was not enough to
fix the actual issue, because the real issue was in podcastparser.

The upstream issue is gpodder/gpodder#394 and the pull request fixing
this is gpodder/podcastparser#17.

Instead of just updating podcastparser, I also updated gpodder to latest
master, because it contains a few more fixes.

I've tested whether this fixes my issue and it did (feed items now have
the correct date).

Signed-off-by: aszlig <aszlig@nix.build>

aszlig added a commit to openlab-aux/vuizvui that referenced this pull request Oct 24, 2018

dnyarri: Drop override for podcastparser
The upstream version 0.6.4 was released 2 months ago and it recently hit
nixpkgs[1], so we can finally drop the override as the new version now
contains the fix[2] for the problem that affected me.

[1]: NixOS/nixpkgs@5e2590b
[2]: gpodder/podcastparser#17

Signed-off-by: aszlig <aszlig@nix.build>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment