Fix crash on download from Navin/ZNEX miniHomer #352
Did our current skytraq test fail on your architecture? Our basic test is invoked with the testo script. It reads scripts in the testo.d directory, e.g. skytraq.test. I would have hoped the test using skytraq-miniHomer2_8.bin would have been capable of finding this bug, at least if run on ARM.
If the test fails w/o the fix, and passes with it, then we can blame our finite test environment (various flavors of ubuntu + windows + macos). But if the test doesn't fail w/o the fix, then it would be desirable to enhance the test.
ubsan can find these if we execute the code:
but, as @kgraefe points out, we only execute the problematic code when we actually have the serial device connected.
I don't see an easy way to improve the test. One might consider:
but these are longer term projects.