feat: add ability to save an assistant #288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedadams
requested review from
StrongMonkey,
g-linville,
njhale and
ryanhopperlowe
thedadams
commented
Aug 26, 2024
| setScriptContent: React.Dispatch<React.SetStateAction<Block[] | null>>; | ||
| tool: Tool; | ||
| setTool: React.Dispatch<React.SetStateAction<Tool>>; | ||
| rootTool: Tool; |
There was a problem hiding this comment.
I keep getting confused that this is only the "root tool" and not the whole tool, so I renamed it. Happy to switch it back if folks disagree with this change.
| } | ||
|
|
||
| // The knowledge tool is dynamic and not controlled by the user. Don't add it to the saved tool. | ||
| const addedTools = tools.filter((t) => t !== knowledgeTool); |
StrongMonkey
approved these changes
Aug 26, 2024
g-linville
approved these changes
Aug 26, 2024
njhale
approved these changes
Aug 26, 2024
|
In my drive, I realized there is a small issue with this. I will fix it tonight. |
ryanhopperlowe
approved these changes
Aug 27, 2024
If a user has added tools to a thread, then they will be able to save the assistant such that these tools become part of the assistant. The only exception to this is the knowledge tool: the user can't explicitly add the knowledge tool, so it will not be saved to the assistant. This will change when a user has the ability to add knowledge to an assistant. Signed-off-by: Donnie Adams <donnie@acorn.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user has added tools to a thread, then they will be able to save the assistant such that these tools become part of the assistant. The only exception to this is the knowledge tool: the user can't explicitly add the knowledge tool, so it will not be saved to the assistant. This will change when a user has the ability to add knowledge to an assistant.