fix: clear tools when new thread is created #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When switching threads, the socket will send back the messages and tools for the thread. However, if the thread state file doesn't exist yet, nothing is sent. This leads to the tools being leftover from the previous thread. This change will emit the event so that the tools are correctly set for a new thread. Signed-off-by: Donnie Adams <donnie@acorn.io>
thedadams
requested review from
StrongMonkey,
g-linville,
iwilltry42,
njhale and
ryanhopperlowe
iwilltry42
approved these changes
Aug 27, 2024
g-linville
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When switching threads, the socket will send back the messages and tools for the thread. However, if the thread state file doesn't exist yet, nothing is sent. This leads to the tools being leftover from the previous thread.
This change will emit the event so that the tools are correctly set for a new thread.