Fix socket reconnect issue that event emitter is lost #53
Conversation
Signed-off-by: Daishan Peng <daishan@acorn.io>
|
|
||
| useEffect(() => { | ||
| if (forceRun && socket && connected) { | ||
| socket.emit("run", script, subTool ? subTool : tool.name, formValues, workspace, thread) |
There was a problem hiding this comment.
@tylerslaton Let me know how you would think about the approach... this is the best way I can think of to trigger the socket re-mount logic during reconnection
There was a problem hiding this comment.
Not a bad approach. I wonder if you could call the restart function from the useChatSocket.tsx here instead since that'll wire a bunch of stuff up on your behalf. That being said, I think what you have works.
There was a problem hiding this comment.
Yeah, trying to avoid the fact that when reconnecting socket we just create a new one. I do feel like the proper solution to handle this in the server side where socket should listen on connect event and remount all the listener, but that's much harder because there are a bunch of paramaters to be passed in when mounting the listener.
|
|
||
| useEffect(() => { | ||
| if (forceRun && socket && connected) { | ||
| socket.emit("run", script, subTool ? subTool : tool.name, formValues, workspace, thread) |
There was a problem hiding this comment.
Not a bad approach. I wonder if you could call the restart function from the useChatSocket.tsx here instead since that'll wire a bunch of stuff up on your behalf. That being said, I think what you have works.
2 participants
This PR fixes an issue where socket's event emitter will be lost once socket is reconnected. This happens when app lost network connection, causing socket to reconnect but the server socket is reconnected and lose all the event listener including user-message. This causes an issue where typing user message doesn't trigger anything in UI.
Added the functionality to manually trigger the
runevent through the socket to re-add all the custom event listeners.