Add gpt-4o-mini to smoke test github workflow and make smoke test judge more reliable #873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Focus comparison on matching event types to reduce false negatives - Drop "ignore callProgress" rule (we're eliding them from the event stream before sending them to the judge now) Signed-off-by: Nick Hale <4175918+njhale@users.noreply.github.com>
njhale
requested review from
g-linville,
ibuildthecloud,
iwilltry42,
ryanhopperlowe,
thedadams and
tylerslaton
njhale
changed the title
- Add gpt-4o-mini to smoke test github workflow - Add gpt-4o-mini smoke test golden files - Remove outdated gpt-4o model and 4-turbo smoke test config and golden files - Add golden files for gpt-4o-2024-08-06 - Regenerate golden files for existing models to drop callProgress events (we weren't comparing these anyway) Signed-off-by: Nick Hale <4175918+njhale@users.noreply.github.com>
njhale
force-pushed
the
test/smoke-4o-mini
branch
from
2380ce1 to
ef6c6fc
Compare
thedadams
approved these changes
Oct 14, 2024
drpebcak
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stream before sending them to the judge now)
Reminder: The workflow from
mainis what runs for PRs, so you won't see smoke tests run forgpt-4o-minion this PR.