Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wgsl: execution tests for assigning AbstractFloat to AbstractFloat #2755

Closed
zoddicus opened this issue Jun 8, 2023 · 1 comment · Fixed by #2756
Closed

wgsl: execution tests for assigning AbstractFloat to AbstractFloat #2755

zoddicus opened this issue Jun 8, 2023 · 1 comment · Fixed by #2756
Assignees
@zoddicus
Labels
wgsl

Comments

@zoddicus
Copy link
Contributor

zoddicus commented Jun 8, 2023

This should always be precise.
This will provide coverage for the infrastructure related to extracting AbstractFloats from shaders
@zoddicus zoddicus added the wgsl label Jun 8, 2023
@zoddicus zoddicus self-assigned this Jun 8, 2023
zoddicus added a commit to zoddicus/cts that referenced this issue Jun 8, 2023
@zoddicus
Implement AF -> AF assignment tests
a337541 
This adds in the core infrastructure for running AbstractFloat
returrning tests. f64 returning tests are forbidden in a few more
places. A inline snippet for extracting a AbstractFloat as two u32s is
used.

Fixes gpuweb#2755
@zoddicus zoddicus mentioned this issue Jun 8, 2023
Merged
7 tasks
@ben-clayton
Copy link
Contributor

The only thing that can be assigned an abstract numeric without concretization is a const, which is can't be reassigned, only initialized.

zoddicus added a commit to zoddicus/cts that referenced this issue Jul 25, 2023
@zoddicus
Implement AF -> AF assignment tests
4dc5d33 
This adds in the core infrastructure for running AbstractFloat
returrning tests. f64 returning tests are forbidden in a few more
places. A inline snippet for extracting a AbstractFloat as two u32s is
used.

Fixes gpuweb#2755
zoddicus added a commit to zoddicus/cts that referenced this issue Jul 31, 2023
@zoddicus
Implement AF -> AF assignment tests
f909d4d 
This adds in the core infrastructure for running AbstractFloat
returrning tests. f64 returning tests are forbidden in a few more
places. A inline snippet for extracting a AbstractFloat as two u32s is
used.

Fixes gpuweb#2755
zoddicus added a commit that referenced this issue Jul 31, 2023
@zoddicus
wgsl: Implement AF -> AF assignment tests (#2756)
a7b4cce 
This adds in the core infrastructure for running AbstractFloat
returning tests. f64 returning tests are forbidden in a few more
places. A inline snippet for extracting an AbstractFloat as two u32s
is used.

Fixes #2755
zoddicus added a commit to zoddicus/cts that referenced this issue Aug 22, 2023
@zoddicus
wgsl: Rework AF support to be two-pass
6a087ae 
This will allow for properly supporting vector results in future PRs.

Issue gpuweb#2755
@zoddicus zoddicus mentioned this issue Aug 22, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zoddicus zoddicus

Labels
wgsl
Projects
CTS
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

wgsl: Implement AF -> AF assignment tests zoddicus/cts
2 participants
@zoddicus @ben-clayton