Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade some gql dependencies #2

Merged
merged 1 commit into from Oct 2, 2019

Conversation

@comigor
Copy link
Contributor

commented Oct 2, 2019

Coming from Artemis, gql dependency is not working due to some conflicts with analyzer->flutter_test dependency tree.

Although Artemis (and gql) are Dart-only libraries, it's best to be in sync with at least flutter beta branch.

This is conjunction with comigor/artemis#35 should be enough to make both libraries work on beta branch.

Coming from Artemis, `gql` dependency is not working due to some conflicts with `analyzer`->`flutter_test` dependency tree.

Although Artemis (and `gql`) are Dart-only libraries, it's best to be in sync with at least flutter beta branch.

This is conjunction with comigor/artemis#35 should be enough to make both libraries work.
@comigor

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2019

Hey @klavs!
Not related to this but how do you feel about a CI pipeline to gql packages? (like I'm doing on Artemis)
At least for PR checks (but it can be done to deploy them to pub.get as well). I will open a PR with settings for GitHub Actions later.

@klavs

This comment has been minimized.

Copy link
Collaborator

commented Oct 2, 2019

Excellent! Thank you for the PR!

@klavs klavs merged commit f77227f into gql-dart:master Oct 2, 2019
@comigor comigor deleted the comigor:downgrade-some-deps branch Oct 2, 2019
@comigor

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2019

Could you please release a new version with this change?

@klavs

This comment has been minimized.

Copy link
Collaborator

commented Oct 2, 2019

@comigor, I'm working on it

@klavs

This comment has been minimized.

Copy link
Collaborator

commented Oct 2, 2019

@comigor, thanks again! The changes are published and I've submitted a PR in Artemis to upgrade the deps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.