Fix long paths in Windows. #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx.py
Outdated
| output.append(os.path.join(root, fname)) | ||
| if output: | ||
| key = lambda x: os.path.getmtime(_safe_path(x)) | ||
| key = lambda x: getmtime(x) |
There was a problem hiding this comment.
This is causing warnings in pylint. You can remove that local variable and use key=getmtime below.
jphalimi-intel
force-pushed
the
WindowsPath
branch
from
7c82122 to
3b6d870
Compare
jphalimi-intel
force-pushed
the
WindowsPath
branch
from
3b6d870 to
2745a98
Compare
|
I fixed the lint issue. thanks for spotting it. |
|
Thanks, looks good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes issues in Windows for long-path related problems.