Skip to content

Fix Node.js start in Windows#10001

Merged
abidlabs merged 4 commits intogradio-app:mainfrom
rrg92:patch-1
Nov 21, 2024
Merged

Fix Node.js start in Windows#10001
abidlabs merged 4 commits intogradio-app:mainfrom
rrg92:patch-1

Conversation

@rrg92
Copy link
Copy Markdown
Contributor

@rrg92 rrg92 commented Nov 19, 2024

Description

Fix node start error in Windows systems, due to file nomenclature. Fix #9903

Closes: #9903

Fix node start error in Windows systems, due to file nomenclature. 
Fix gradio-app#9903
@yvrjsharma yvrjsharma mentioned this pull request Nov 21, 2024
1 task
@yvrjsharma
Copy link
Copy Markdown
Collaborator

This fixes issue #9903 for me on a Windows 11 machine. I also left a detailed comment here.

@yvrjsharma yvrjsharma self-assigned this Nov 21, 2024
Copy link
Copy Markdown
Collaborator

@yvrjsharma yvrjsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue #9903 for me on a windows 11 machine.

@gradio-pr-bot
Copy link
Copy Markdown
Collaborator

gradio-pr-bot commented Nov 21, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/9c3e17182e923bc2f18cb1243fed540ac81ab04b/gradio-5.6.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@9c3e17182e923bc2f18cb1243fed540ac81ab04b#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/9c3e17182e923bc2f18cb1243fed540ac81ab04b/gradio-client-1.8.0.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/9c3e17182e923bc2f18cb1243fed540ac81ab04b/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Copy Markdown
Collaborator

gradio-pr-bot commented Nov 21, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix Node.js start in Windows

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs
Copy link
Copy Markdown
Member

Thanks for the contribution @rrg92! We'll get this merged in once CI passes

@abidlabs abidlabs enabled auto-merge (squash) November 21, 2024 15:16
@abidlabs abidlabs merged commit f2fa270 into gradio-app:main Nov 21, 2024
@rrg92
Copy link
Copy Markdown
Contributor Author

rrg92 commented Nov 21, 2024

Thank you fast answer and reviews!

@JackismyShephard
Copy link
Copy Markdown
Contributor

@abidlabs What is the ETA on the release of the next gradio version with this fix?

@abidlabs
Copy link
Copy Markdown
Member

Probably early next week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error loading SSR mode

5 participants