remove-queue-from-events #1056
Merged
remove-queue-from-events #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
omerXfaruq
commented
Apr 21, 2022
omerXfaruq
commented
- enable_queue exists just under Blocks.launch()
- enable_queue exists just under Blocks.launch()
omerXfaruq
force-pushed
the
remove-queue-from-events
branch
from
d82187a
to
a04a748
Compare
- enable_queue exists just under Blocks.launch()
- fix tests
|
Seems reasonable to me, will let @aliabid94 review this one |
* spaces-defaults - enable_queue and cache_examples are activated in spaces in default option * spaces-defaults - tweaks
|
LGTM. I do wonder if there will be cases where a Blocks will have one event that takes a long time, and one that is instantaneous, and bc of queueing, the quick one has to wait behind the long one. We can wait and see if we have users with that problem |
|
Thanks for the quick review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.