Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to control page title, default to false #2400

Merged
merged 4 commits into from Oct 7, 2022
Merged

Conversation

pngwn
Copy link
Member

@pngwn pngwn commented Oct 6, 2022

Description

Adds option to the gradio-app webcomponent to dictate whether or not the gradio app should set the HTML documents title. This is set to false by default. It is set to true in Gradio's own templates (because the gradio app is the whole app in that case).

I've tested it with the ui/packages/cdn_test. You can too:

From ui:

pnpm build:cdn-local
pnpm preview:cdn-local

You can add + remove the control_page_title option added to the webcomponent in that package to see the effect.

Closes: #2065

Checklist:

  • I have performed a self-review of my own code
  • I have added a short summary of my change to the CHANGELOG.md
  • My code follows the style guidelines of this project
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

A note about the CHANGELOG

Hello 馃憢 and thank you for contributing to Gradio!

All pull requests must update the change log located in CHANGELOG.md, unless the pull request is labeled with the "no-changelog-update" label.

Please add a brief summary of the change to the Upcoming Release > Full Changelog section of the CHANGELOG.md file and include
a link to the PR (formatted in markdown) and a link to your github profile (if you like). For example, "* Added a cool new feature by [@myusername](link-to-your-github-profile) in [PR 11111](https://github.com/gradio-app/gradio/pull/11111)".

If you would like to elaborate on your change further, feel free to include a longer explanation in the other sections.
If you would like an image/gif/video showcasing your feature, it may be best to edit the CHANGELOG file using the
GitHub web UI since that lets you upload files directly via drag-and-drop.

@pngwn pngwn requested a review from abidlabs October 6, 2022 15:43
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-2400-all-demos

Copy link
Collaborator

@aliabid94 aliabid94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pngwn pngwn merged commit 8f43b62 into main Oct 7, 2022
@pngwn pngwn deleted the 2065-wc-title branch October 7, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web component Embed changes title
3 participants