Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3d Image Component #775

Merged
merged 21 commits into from Mar 31, 2022
Merged

3d Image Component #775

merged 21 commits into from Mar 31, 2022

Conversation

dawoodkhan82
Copy link
Collaborator

Description

Please include:

  • relevant motivation
  • a summary of the change
  • which issue is fixed.
  • any additional dependencies that are required for this change.

Fixes: # (issue)

Checklist:

  • I have performed a self-review of my own code
  • My code follows the style guidelines of this project
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@abidlabs
Copy link
Member

abidlabs commented Mar 7, 2022

Generally looks fine. As discussed, we'll hold off merging this until the components are merged. In the meantime, some small things:

  • code needs to be formatted
  • we should add tests for this component
  • we should add a demo for the input component as well

We should confirm that this works with a "real" ML model.

@dawoodkhan82 dawoodkhan82 changed the title 3d Image Component [WIP] 3d Image Component Mar 9, 2022
@omerXfaruq omerXfaruq force-pushed the master branch 4 times, most recently from 5712245 to 5f907e4 Compare March 14, 2022 17:31
@dawoodkhan82 dawoodkhan82 changed the title [WIP] 3d Image Component 3d Image Component Mar 31, 2022
@dawoodkhan82 dawoodkhan82 merged commit 82f6a3f into main Mar 31, 2022
@dawoodkhan82 dawoodkhan82 deleted the dawood/3d-image branch March 31, 2022 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants