Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample-check brings in slf4j-simple dependency #26

Closed
lptr opened this issue Aug 22, 2018 · 2 comments
Closed

Sample-check brings in slf4j-simple dependency #26

lptr opened this issue Aug 22, 2018 · 2 comments
Assignees

Comments

@lptr
Copy link
Member

lptr commented Aug 22, 2018

https://github.com/gradle/exemplar/blob/master/sample-check/build.gradle.kts#L15-L17

The problem with this is that it collides with Gradle's own SLF4J implementation, producing the following output whenever an integration test is executed:

SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [file:/Users/lptr/Workspace/gradle/gradle/out/production/logging/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/Users/lptr/.gradle/caches/modules-2/files-2.1/org.slf4j/slf4j-simple/1.7.16/f0cacc3d21e1027c82006a7a6f6cf2cad86d2a4f/slf4j-simple-1.7.16.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.gradle.internal.logging.slf4j.OutputEventListenerBackedLoggerContext]

I guess it should be up to the user of this library to decide what SLF4J bindings they want to use.

@lptr
Copy link
Member Author

lptr commented Aug 23, 2018

Looks like the dependency on SLF4J is mostly removed in master and should be fixed by releasing 0.5.0. I guess the libraries should be removed from Dependencies.kt as well, but that's not relevant to fixing this issue.

@eriwen
Copy link
Contributor

eriwen commented Sep 6, 2018

This is fixed in Exemplar v0.6.0

@eriwen eriwen closed this as completed Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants