Permalink
Browse files

Javadoc tweaks, fixed a typo, removed some logging.

  • Loading branch information...
1 parent e8ad707 commit c9e46c6ac792732bf370f4a6356176f13047bd39 @adammurdoch adammurdoch committed Apr 17, 2012
@@ -13,28 +13,16 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-
-
-
package org.gradle.api.plugins.quality.internal.findbugs
import org.gradle.api.file.FileCollection
import org.gradle.api.internal.project.ProjectInternal
-import org.gradle.api.logging.Logger
-import org.gradle.api.logging.Logging
import org.gradle.process.internal.JavaExecHandleBuilder
import org.gradle.process.internal.WorkerProcess
import org.gradle.process.internal.WorkerProcessBuilder
class FindBugsDaemonManager {
- private final Logger logger = Logging.getLogger(getClass())
-
public FindBugsResult runDaemon(ProjectInternal project, FileCollection findBugsClasspath, FindBugsSpec spec) {
- logger.info("Starting Gradle findbugs daemon.");
- if (logger.isDebugEnabled()) {
- logger.debug(findBugsClasspath.asPath);
- }
-
WorkerProcess process = createWorkerProcess(project, findBugsClasspath, spec);
process.start();
@@ -43,7 +31,6 @@ class FindBugsDaemonManager {
FindBugsResult result = clientCallBack.getResult();
process.waitForStop();
- logger.info("Gradle findbugs daemon stopped.");
return result;
}
@@ -71,7 +71,7 @@ public File getTempFile() {
private void saveIntoFileStore(File contentFile, File storageFile) {
File parentDir = storageFile.getParentFile();
if (!parentDir.mkdirs() && !parentDir.exists()) {
- throw new GradleException(String.format("Unabled to create filestore directory %s", parentDir));
+ throw new GradleException(String.format("Unable to create filestore directory %s", parentDir));
}
if (!contentFile.renameTo(storageFile)) {
throw new GradleException(String.format("Failed to copy downloaded content into storage file: %s", storageFile));
@@ -20,8 +20,10 @@
public interface FileLock extends Closeable, FileAccess {
/**
- * Returns true if the most recent {@link #updateFile(Runnable)} by any process succeeded (ie a process did not crash while updating
- * the target file). Returns false if {@link #updateFile(Runnable)} has never been called for the target file.
+ * Returns true if the most recent mutation method ({@link #updateFile(Runnable)} or {@link #writeFile(Runnable)} attempted by any process succeeded
+ * (ie a process did not crash while updating the target file).
+ *
+ * Returns false if no mutation method has been called for the target file.
*/
boolean getUnlockedCleanly();
@@ -25,6 +25,9 @@
import java.util.Collection;
import java.util.List;
+/**
+ * An immutable classpath.
+ */
public class DefaultClassPath implements ClassPath, Serializable {
private final List<File> files;

0 comments on commit c9e46c6

Please sign in to comment.