Permalink
Commits on Aug 26, 2016
  1. @bigdaz

    Remove handling for build-targeting in rules

    The ability to target a project dependency like `build::project:path`
    was introduced earlier, however this has been supplanted by the fact
    that project dependencies within an `includeBuild` declaration are
    interpreted relative to the included build.
    bigdaz committed Aug 25, 2016
  2. @melix
  3. @melix
  4. @bmuschko
  5. @wolfs

    Add unit test for NativePlatformConsoleDetector

    GRADLE-2634
    +review REVIEW-6199
    wolfs committed Aug 26, 2016
  6. @wolfs
  7. @melix

    Fix wrong map being used for `put`

    melix committed Aug 26, 2016
  8. @melix

    Fix compilation under JDK 7

    melix committed Aug 26, 2016
  9. @melix
  10. @melix

    Add missing header

    melix committed Aug 26, 2016
  11. @melix

    Implement Android Studio Mockup performance test

    This commit adds a new kind of cross-version performance test which simulates the behavior of Gradle under Android Studio.
    The first simulation is based on project synchronization and relies on previous work found on the android-studio-sync-test
    (https://github.com/adammurdoch/android-studio-sync-test) project.
    
    It's worth noting that the classes in `internal-android-performance-testing` are collecting some statistics which are *not*
    used when generating the reports. This commit just setups the basic infrastructure for performance testing of Android projects
    in the context of Android Studio.
    
    Some implementation notes:
    
    - the custom model used when calling the Tooling API live in a dedicated project (`internalAndroidPerformanceTesting`) so that
    we can generate a JAR that can in turn be added to the classpath when executing the test. This allows us to precompile the model
    class and limit the impact of using Groovy to collect statistics.
    - the `internalAndroidPerformanceTesting` project uses a trick to workaround an issue with some Android dependencies which
    provide a `gradle-core` jar. This is problematic because our module lookup finds this jar first and tries to load it as the
    main Gradle module, although it's not. For that reason, the dependencies are renamed (prefixed with `android-`) and added to
    the classpath, avoiding this name clash.
    - this classpath, as well as the generated custom model classes, are written in a `tapi-classpath.txt` file which is then
    used by the performance test runner to set the tooling api classpath.
    melix committed Aug 26, 2016
  12. @wolfs

    Polish ExecIntegrationSpec even more

    GRADLE-3528
    +review REVIEW-6191
    wolfs committed Aug 26, 2016
  13. @wolfs

    Modernize ExecIntegrationSpec

    GRADLE-3528
    +review REVIEW-6191
    wolfs committed Aug 26, 2016
  14. @wolfs

    Close HttpResponse in finally block

    GRADLE-3518
    REVIEW-6201
    wolfs committed Aug 26, 2016
  15. @bmuschko

    Make test more clear

    bmuschko committed Aug 26, 2016
  16. @wolfs

    Make integration test respect @NotYetImplemented

    When the exception is thrown from a rule
    @NotYetImplemented does not work.
    wolfs committed Aug 26, 2016
  17. @wolfs

    Close responses from httpclient

    Since Apache HttpClient 4.3 `(Closable)HttpResponse`s
    need to be closed. Gradle has not been doing that after
    the upgrade to HttpClient 4.4. This probably caused some
    resource problems.
    
    GRADLE-3518
    wolfs committed Aug 26, 2016
  18. @bmuschko

    Remove second invocation of sample code execution

    Before it failed with java.lang.ClassNotFoundException: org.example.TemplateEngineType. This seems to be an issue with the sample code execution of some sort. Still needs investigation.
    
    +review REVIEW-6197
    bmuschko committed Aug 26, 2016
  19. @ghale

    Remove LRUDaemonExpirationStrategy as this concern is mostly met by D…

    …uplicateIdleDaemonExpirationStrategy
    
    +review REVIEW-6160
    ghale committed Aug 26, 2016
  20. @ghale

    Cleanup of some issues with daemon cancels build on client disconnect

    - When build is canceled after a stop is already requested, stop immediately
    - Be consistent with timeout units in DuplicateIdleDaemonExpirationStrategy
    - Simplify canceled daemon connection strategy
    
    +review REVIEW-6160
    ghale committed Aug 26, 2016
  21. @wolfs

    Add an integration test for cacheChangingModulesFor and inherited con…

    …figurations
    
    GRADLE-3524
    wolfs committed Aug 26, 2016
  22. @bmuschko
  23. @wolfs

    Make Gradle run when TERM is not set

    I didn't manage to reproduce the issue
    with an integration test since
    I could not remove the TERM variable from the environment
    of the forked Gradle process. Even starting it via a shell script
    having `unset TERM` before the actual Gradle call didn't
    make this error surface. It is very easy to reproduce on the
    command line.
    
    GRADLE-2634
    +review REVIEW
    wolfs committed Aug 26, 2016
  24. @wolfs

    Add @Issue annotation to test

    GRADLE-3530
    +review REVIEW-6198
    wolfs committed Aug 26, 2016
Commits on Aug 25, 2016
  1. @eriwen
  2. @eriwen
  3. @eriwen

    Revert "Update gradle-build-tag-plugin to 0.10."

    This reverts commit c836372.
    eriwen committed Aug 25, 2016
  4. @wolfs

    Fix extra property lookup order for grand children

    It looks like for grand children of the root
    project we were first looking up `ExtraProperties`
    in the root project and then in the child project.
    
    Changing the order could have a performance impact,
    so this probably needs to be revisited after having a
    look at the performance tests.
    
    The order of `snapshotInheritable()` is now the same as
    in `updateDelegates`.
    
    GRADLE-3530 #resolve
    +review REVIEW
    wolfs committed Aug 25, 2016
  5. @wolfs
  6. @eriwen
  7. @melix
  8. @bmuschko

    Prefer xref to different chapter

    +review REVIEW-6197
    bmuschko committed Aug 25, 2016
  9. @bmuschko

    Fix link

    +review REVIEW-6197
    bmuschko committed Aug 25, 2016
  10. @bigdaz

    Revert fat locking of `IncludedBuildExecuter`

    This fat lock was introduced in order to avoid thread-safety issues when
    executing a composite build with `--parallel`. However this change
    introduced a deadlock condition due to the lock being too coarse-
    grained.
    
    Reverting this change should fix the deadlock, however the potential for
    a 'dependency cycle' being reported when executing composite builds with
    `--parallel` remains, I think.
    bigdaz committed Aug 25, 2016
  11. @melix

    Add `largeAndroidBuild` template

    This commit adds a performance test for the "large" Android build. The build is an external project.
    There's still WIP to make this project relevant for our tests, but this commit makes it possible to
    test the integration with our perf test suite.
    melix committed Aug 25, 2016